[PATCH 03/10] admin: hoist out resolve_git_dir

[Eric Wong <e@80x24.org>]

We'll be using this for indexing git coderepos.
---
 lib/PublicInbox/Admin.pm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Admin.pm b/lib/PublicInbox/Admin.pm
index 11ea8f83..a3b41d99 100644
--- a/lib/PublicInbox/Admin.pm
+++ b/lib/PublicInbox/Admin.pm
@@ -69,13 +69,19 @@ sub resolve_inboxdir {
 			die "`$try' is not a directory\n";
 		}
 	}
+	my $dir = resolve_git_dir($cd);
+	$$ver = 1 if $ver;
+	$dir;
+}
+
+sub resolve_git_dir {
+	my ($cd) = @_;
 	# try v1 bare git dirs
 	my $cmd = [ qw(git rev-parse --git-dir) ];
 	my $fh = popen_rd($cmd, undef, {-C => $cd});
 	my $dir = do { local $/; <$fh> };
-	close $fh or die "error in @$cmd (cwd:${\($cd // '.')}): $!\n";
+	close $fh or die "error in @$cmd (cwd:${\($cd // '.')}): $?\n";
 	chomp $dir;
-	$$ver = 1 if $ver;
 	rel2abs_collapsed($dir eq '.' ? ($cd // $dir) : $dir);
 }