From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH] config: describe order dependency in cgitrc parsing
Date: Mon, 13 Mar 2023 22:14:42 +0000 [thread overview]
Message-ID: <20230313221442.4001281-1-e@80x24.org> (raw)
I just had to do a double-take here and look back at cgit.c
to see the ordering dependency wasn't a bug I introduced,
but mimicking what cgit does.
---
lib/PublicInbox/Config.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index cdf06d85..becf176a 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -316,6 +316,8 @@ sub parse_cgitrc {
$k =~ tr/-/_/;
$self->{"-cgit_$k"} = $v;
} elsif (m!\Ascan-path=(.+)\z!) {
+ # this depends on being after project-list in the
+ # config file, just like cgit.c
if (defined(my $list = $self->{-cgit_project_list})) {
scan_projects_coderepo($self, $list, $1);
} else {
reply other threads:[~2023-03-13 22:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313221442.4001281-1-e@80x24.org \
--to=e@80x24.org \
--cc=spew@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).