dumping ground for random patches and texts
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 3/3] lei_mirror: do not fetch to read-only directories
Date: Sun, 12 Mar 2023 22:42:08 +0000	[thread overview]
Message-ID: <20230312224208.1801152-3-e@80x24.org> (raw)
In-Reply-To: <20230312224208.1801152-1-e@80x24.org>

As with public-inbox-fetch, we shouldn't waste time fetching
into read-only directories, since --epoch= will make unwanted
epoch directories read-only placeholders.
---
 lib/PublicInbox/LeiMirror.pm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm
index 967a6422..3ec8170f 100644
--- a/lib/PublicInbox/LeiMirror.pm
+++ b/lib/PublicInbox/LeiMirror.pm
@@ -593,8 +593,15 @@ sub clone_v1 {
 		die "$uri is a v1 inbox, --epoch is not supported\n";
 	$self->{-torsocks} //= $curl->torsocks($lei, $uri) or return;
 	my $dst = $self->{cur_dst} // $self->{dst};
-	my $fini = PublicInbox::OnDestroy->new($$, \&v1_done, $self);
 	my $resume = -d $dst;
+	if ($resume) { # respect read-only cloned w/ --epoch=
+		my @st = stat(_); # for root
+		if (!-w _ || !($st[2] & 0222)) {
+			warn "# skipping $dst, not writable\n";
+			return;
+		}
+	}
+	my $fini = PublicInbox::OnDestroy->new($$, \&v1_done, $self);
 	if (my $fgrp = forkgroup_prep($self, $uri)) {
 		$fgrp->{-fini} = $fini;
 		if ($resume) {

      parent reply	other threads:[~2023-03-12 22:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-12 22:42 [PATCH 1/3] lei_mirror: describe why the {ibx} field is used Eric Wong
2023-03-12 22:42 ` [PATCH 2/3] lei_mirror: do not re-fetch inbox.config.example Eric Wong
2023-03-12 22:42 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230312224208.1801152-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=spew@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).