dumping ground for random patches and texts
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH] test/ruby/test_autoload: hoist out ruby_impl_require
Date: Thu,  5 Nov 2015 21:57:35 +0000	[thread overview]
Message-ID: <20151105215735.22811-1-e@80x24.org> (raw)

Having "require" implemented in Ruby is the common case nowadays
with RubyGems, so ensure it is easy-to-reuse the same code.
---
 test/ruby/test_autoload.rb | 33 ++++++++++++++++++---------------
 1 file changed, 18 insertions(+), 15 deletions(-)

diff --git a/test/ruby/test_autoload.rb b/test/ruby/test_autoload.rb
index ed73138..719502d 100644
--- a/test/ruby/test_autoload.rb
+++ b/test/ruby/test_autoload.rb
@@ -187,31 +187,34 @@ p Foo::Bar
     }
   end
 
-  def test_require_implemented_in_ruby_is_called
+  def ruby_impl_require
     Kernel.module_eval do; alias :old_require :require; end
-
     called_with = []
     Kernel.send :define_method, :require do |path|
       called_with << path
       old_require path
     end
-
-    Tempfile.create(['autoload', '.rb']) {|file|
-      file.puts 'class AutoloadTest; end'
-      file.close
-      add_autoload(file.path)
-      begin
-        assert(Object::AutoloadTest)
-      ensure
-        remove_autoload_constant
-      end
-      assert_equal [file.path], called_with
-    }
-
+    yield called_with
   ensure
     Kernel.module_eval do; alias :require :old_require; undef :old_require; end
   end
 
+  def test_require_implemented_in_ruby_is_called
+    ruby_impl_require do |called_with|
+      Tempfile.create(['autoload', '.rb']) {|file|
+        file.puts 'class AutoloadTest; end'
+        file.close
+        add_autoload(file.path)
+        begin
+          assert(Object::AutoloadTest)
+        ensure
+          remove_autoload_constant
+        end
+        assert_equal [file.path], called_with
+      }
+    end
+  end
+
   def add_autoload(path)
     (@autoload_paths ||= []) << path
     ::Object.class_eval {autoload(:AutoloadTest, path)}
-- 
EW


                 reply	other threads:[~2015-11-05 21:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105215735.22811-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=spew@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).