From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: spew@80x24.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id CB3F51F7DB for ; Fri, 14 Aug 2015 09:50:32 +0000 (UTC) From: Eric Wong To: spew@80x24.org Subject: [PATCH] method.h: cast checks to int for >= 0 checks Date: Fri, 14 Aug 2015 09:50:32 +0000 Message-Id: <1439545832-17296-1-git-send-email-e@80x24.org> List-Id: Setting VM_CHECK_MODE to 1 in vm_core.h makes noisy warnings otherwise. AFAIK, the signedness of enums is implementation-dependent, and GCC considers them unsigned and warns. Tested on gcc 4.7.2 (Debian 4.7.2-5) * method.h (METHOD_ENTRY_VISI_SET): cast visi to int (METHOD_ENTRY_FLAGS_SET): ditto --- method.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/method.h b/method.h index e46ba55..71dc2c0 100644 --- a/method.h +++ b/method.h @@ -68,7 +68,7 @@ typedef struct rb_callable_method_entry_struct { /* same fields with rb_method_e static inline void METHOD_ENTRY_VISI_SET(rb_method_entry_t *me, rb_method_visibility_t visi) { - VM_ASSERT(visi >= 0 && visi <= 3); + VM_ASSERT((int)visi >= 0 && visi <= 3); me->flags = (me->flags & ~(IMEMO_FL_USER0 | IMEMO_FL_USER1)) | (visi << IMEMO_FL_USHIFT+0); } static inline void @@ -86,7 +86,7 @@ METHOD_ENTRY_SAFE_SET(rb_method_entry_t *me, unsigned int safe) static inline void METHOD_ENTRY_FLAGS_SET(rb_method_entry_t *me, rb_method_visibility_t visi, unsigned int basic, unsigned int safe) { - VM_ASSERT(visi >= 0 && visi <= 3); + VM_ASSERT((int)visi >= 0 && visi <= 3); VM_ASSERT(basic <= 1); VM_ASSERT(safe <= 1); me->flags = -- EW