From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.3 required=3.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: spew@80x24.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id CFE2B633802 for ; Tue, 23 Jun 2015 02:04:29 +0000 (UTC) From: Eric Wong To: spew@80x24.org Subject: [PATCH] socket: cache common socket families in fptr->mode Date: Tue, 23 Jun 2015 02:04:29 +0000 Message-Id: <1435025069-22717-1-git-send-email-e@80x24.org> List-Id: require 'socket' require 'benchmark' nr = 100000 msg = 'hello world' buf = '' size = msg.bytesize puts(Benchmark.measure do UNIXSocket.pair(:SEQPACKET) do |a, b| nr.times do a.sendmsg(msg) b.recv(size, 0, buf) end end end) user system total real before: 0.230000 0.290000 0.520000 ( 0.528830) after: 0.160000 0.270000 0.430000 ( 0.432404) --- ext/socket/ancdata.c | 4 ++-- ext/socket/basicsocket.c | 4 ++-- ext/socket/init.c | 23 +++++++++++++++++++++-- ext/socket/rubysocket.h | 8 +++++++- include/ruby/io.h | 3 +++ 5 files changed, 35 insertions(+), 7 deletions(-) diff --git a/ext/socket/ancdata.c b/ext/socket/ancdata.c index 614c8f3..0ccf30c 100644 --- a/ext/socket/ancdata.c +++ b/ext/socket/ancdata.c @@ -1146,7 +1146,7 @@ bsock_sendmsg_internal(int argc, VALUE *argv, VALUE sock, int nonblock) GetOpenFile(sock, fptr); #if defined(HAVE_STRUCT_MSGHDR_MSG_CONTROL) - family = rsock_getfamily(fptr->fd); + family = rsock_getfamily(fptr); #endif data = vflags = dest_sockaddr = Qnil; @@ -1704,7 +1704,7 @@ bsock_recvmsg_internal(int argc, VALUE *argv, VALUE sock, int nonblock) ); #if defined(HAVE_STRUCT_MSGHDR_MSG_CONTROL) - family = rsock_getfamily(fptr->fd); + family = rsock_getfamily(fptr); if (mh.msg_controllen) { char *msg_end = (char *)mh.msg_control + mh.msg_controllen; for (cmh = CMSG_FIRSTHDR(&mh); cmh != NULL; cmh = CMSG_NXTHDR(&mh, cmh)) { diff --git a/ext/socket/basicsocket.c b/ext/socket/basicsocket.c index 6bc1828..16fa12d 100644 --- a/ext/socket/basicsocket.c +++ b/ext/socket/basicsocket.c @@ -214,7 +214,7 @@ bsock_setsockopt(int argc, VALUE *argv, VALUE sock) } GetOpenFile(sock, fptr); - family = rsock_getfamily(fptr->fd); + family = rsock_getfamily(fptr); level = rsock_level_arg(family, lev); option = rsock_optname_arg(family, level, optname); @@ -311,7 +311,7 @@ bsock_getsockopt(VALUE sock, VALUE lev, VALUE optname) int family; GetOpenFile(sock, fptr); - family = rsock_getfamily(fptr->fd); + family = rsock_getfamily(fptr); level = rsock_level_arg(family, lev); option = rsock_optname_arg(family, level, optname); len = 256; diff --git a/ext/socket/init.c b/ext/socket/init.c index 34f6a11..00e20fa 100644 --- a/ext/socket/init.c +++ b/ext/socket/init.c @@ -624,15 +624,34 @@ rsock_s_accept(VALUE klass, int fd, struct sockaddr *sockaddr, socklen_t *len) } int -rsock_getfamily(int sockfd) +rsock_getfamily(rb_io_t *fptr) { union_sockaddr ss; socklen_t sslen = (socklen_t)sizeof(ss); + int cached = fptr->mode & FMODE_SOCK; + + if (cached) { + switch (cached) { +#ifdef AF_UNIX + case FMODE_UNIX: return AF_UNIX; +#endif + case FMODE_INET: return AF_INET; + case FMODE_INET6: return AF_INET6; + } + } ss.addr.sa_family = AF_UNSPEC; - if (getsockname(sockfd, &ss.addr, &sslen) < 0) + if (getsockname(fptr->fd, &ss.addr, &sslen) < 0) return AF_UNSPEC; + switch (ss.addr.sa_family) { +#ifdef AF_UNIX + case AF_UNIX: fptr->mode |= FMODE_UNIX; break; +#endif + case AF_INET: fptr->mode |= FMODE_INET; break; + case AF_INET6: fptr->mode |= FMODE_INET6; break; + } + return ss.addr.sa_family; } diff --git a/ext/socket/rubysocket.h b/ext/socket/rubysocket.h index d03b1c5..79dd783 100644 --- a/ext/socket/rubysocket.h +++ b/ext/socket/rubysocket.h @@ -232,6 +232,12 @@ extern int rsock_do_not_reverse_lookup; extern int rsock_cmsg_cloexec_state; #define FMODE_NOREVLOOKUP 0x100 +/* common socket families only */ +#define FMODE_UNIX 0x00200000 +#define FMODE_INET 0x00400000 +#define FMODE_INET6 0x00800000 +#define FMODE_SOCK (FMODE_UNIX|FMODE_INET|FMODE_INET6) + extern VALUE rb_cBasicSocket; extern VALUE rb_cIPSocket; extern VALUE rb_cTCPSocket; @@ -279,7 +285,7 @@ int rsock_optname_arg(int family, int level, VALUE optname); int rsock_cmsg_type_arg(int family, int level, VALUE type); int rsock_shutdown_how_arg(VALUE how); -int rsock_getfamily(int sockfd); +int rsock_getfamily(rb_io_t *fptr); struct rb_addrinfo { struct addrinfo *ai; diff --git a/include/ruby/io.h b/include/ruby/io.h index 048090c..029522b 100644 --- a/include/ruby/io.h +++ b/include/ruby/io.h @@ -113,6 +113,9 @@ typedef struct rb_io_t { #define FMODE_TEXTMODE 0x00001000 /* #define FMODE_PREP 0x00010000 */ #define FMODE_SETENC_BY_BOM 0x00100000 +/* #define FMODE_UNIX 0x00200000 */ +/* #define FMODE_INET 0x00400000 */ +/* #define FMODE_INET6 0x00800000 */ #define GetOpenFile(obj,fp) rb_io_check_closed((fp) = RFILE(rb_io_taint_check(obj))->fptr) -- EW