From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 3/3] lib/webrick/server.rb: avoid redundant fcntl call
Date: Mon, 11 May 2015 20:17:32 +0000 [thread overview]
Message-ID: <1431375452-6061-3-git-send-email-e@80x24.org> (raw)
In-Reply-To: <1431375452-6061-1-git-send-email-e@80x24.org>
Sockets are close-on-exec by default since Ruby 2.0, so it
is redundant to set it again.
---
lib/webrick/server.rb | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/webrick/server.rb b/lib/webrick/server.rb
index 815375f..5ada88a 100644
--- a/lib/webrick/server.rb
+++ b/lib/webrick/server.rb
@@ -263,7 +263,6 @@ module WEBrick
sock = svr.accept
sock.sync = true
Utils::set_non_blocking(sock)
- Utils::set_close_on_exec(sock)
rescue Errno::ECONNRESET, Errno::ECONNABORTED,
Errno::EPROTO, Errno::EINVAL
rescue StandardError => ex
--
EW
prev parent reply other threads:[~2015-05-11 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 20:17 [PATCH 1/3] lib/webrick/utils.rb: simplify by avoiding fcntl Eric Wong
2015-05-11 20:17 ` [PATCH 2/3] lib/drb/*.rb: avoid redundant fcntl call Eric Wong
2015-05-11 20:17 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431375452-6061-3-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=spew@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).