From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0E6C71F953 for ; Fri, 7 Jan 2022 09:42:21 +0000 (UTC) Received: from localhost ([::1]:43530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5llL-0002hr-1b for e@80x24.org; Fri, 07 Jan 2022 04:42:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5leJ-0000m7-LD for dtas-all@nongnu.org; Fri, 07 Jan 2022 04:35:03 -0500 Received: from dcvr.yhbt.net ([64.71.152.64]:47064) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5leH-0000Hu-Rc for dtas-all@nongnu.org; Fri, 07 Jan 2022 04:35:03 -0500 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D27A41F953; Fri, 7 Jan 2022 09:35:00 +0000 (UTC) Date: Fri, 7 Jan 2022 09:35:00 +0000 From: Eric Wong To: dtas-all@nongnu.org Subject: [PATCH 6/4] doc: drop ordered map from examples Message-ID: <20220107093500.GB18116@dcvr> References: <20220107053544.31240-1-e@80x24.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220107053544.31240-1-e@80x24.org> Received-SPF: pass client-ip=64.71.152.64; envelope-from=e@80x24.org; helo=dcvr.yhbt.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: dtas-all@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: duct tape audio suite List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dtas-all-bounces+e=80x24.org@nongnu.org Sender: "dtas-all" "omap" is specific to Ruby and makes interopability with other languages more difficult. While it's true environment variables are stored as an ordered array of C strings (see environ(7)); order doesn't matter in practice. Everyone in the real world treats the environment as an unordered key-value store, and we shall follow. --- Documentation/dtas-splitfx.pod | 4 ++-- examples/splitfx.sample.yml | 2 +- examples/tfx.sample.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/dtas-splitfx.pod b/Documentation/dtas-splitfx.pod index f10c6a3..717cfa6 100644 --- a/Documentation/dtas-splitfx.pod +++ b/Documentation/dtas-splitfx.pod @@ -90,9 +90,9 @@ moves printing of output to stderr and disables parallel job invocation. =item infile - string, the pathname of the original audio file -=item env - ordered hash of environment variables to set for all commands +=item env - hash of environment variables to set for all commands - env: !omap + env: FX: gain 3 stats =item comments - hash of common tags for all audio (e.g. ARTIST, ALBUM, YEAR) diff --git a/examples/splitfx.sample.yml b/examples/splitfx.sample.yml index 9c29df2..979ba0d 100644 --- a/examples/splitfx.sample.yml +++ b/examples/splitfx.sample.yml @@ -11,7 +11,7 @@ comments: # the sox command for dtas-player playback, there is no need to # specify this as it is the default: # command: exec sox "$INFILE" $SOXFMT - $TRIMFX $RGFX $FX -env: !omap +env: PATH: $PATH # these effects may be used in any command in this file, including targets SOX_OPTS: $SOX_OPTS -R diff --git a/examples/tfx.sample.yml b/examples/tfx.sample.yml index b8add0b..144129f 100644 --- a/examples/tfx.sample.yml +++ b/examples/tfx.sample.yml @@ -4,7 +4,7 @@ # test_trimfx.rb relies on this. --- infile: foo.flac -env: !omap +env: PATH: $PATH SOX_OPTS: $SOX_OPTS -R I2: second.flac