From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 208.118.235.0/24 X-Spam-Status: No, score=-2.4 required=3.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: dtas-all@80x24.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 969CE1FA5B for ; Mon, 18 May 2015 07:51:11 +0000 (UTC) Received: from localhost ([::1]:39534 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuFpP-0002Rd-1Y for dtas-all@80x24.org; Mon, 18 May 2015 03:51:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuFpN-0002R4-M8 for dtas-all@nongnu.org; Mon, 18 May 2015 03:51:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuFpJ-0008NA-7d for dtas-all@nongnu.org; Mon, 18 May 2015 03:51:09 -0400 Received: from dcvr.yhbt.net ([64.71.152.64]:48786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuFpJ-0008My-2S for dtas-all@nongnu.org; Mon, 18 May 2015 03:51:05 -0400 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A929A1F515; Mon, 18 May 2015 07:51:02 +0000 (UTC) From: Eric Wong To: Subject: [PATCH] splitfx: remove support for encoding opus Date: Mon, 18 May 2015 07:51:01 +0000 Message-Id: <1431935461-13338-1-git-send-email-e@80x24.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.71.152.64 Cc: Eric Wong X-BeenThere: dtas-all@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dtas-all-bounces+dtas-all=80x24.org@nongnu.org Sender: dtas-all-bounces+dtas-all=80x24.org@nongnu.org Lossy file encoding has too many tunable variables and it is not a good fit for an audio production tool such as dtas-splitfx. This was becoming a maintenance burden for me and is a sign of featuritis. --- lib/dtas/splitfx.rb | 15 --------------- test/test_splitfx.rb | 29 ----------------------------- 2 files changed, 44 deletions(-) diff --git a/lib/dtas/splitfx.rb b/lib/dtas/splitfx.rb index 9420faf..6bac27f 100644 --- a/lib/dtas/splitfx.rb +++ b/lib/dtas/splitfx.rb @@ -77,21 +77,6 @@ class DTAS::SplitFX # :nodoc: "channels" => 2, }, }, - "opusenc" => { - "command" => 'sox "$INFILE" $COMMENTS $OUTFMT - ' \ - '$TRIMFX $FX $RATEFX $DITHERFX | opusenc --music ' \ - '--raw-bits $BITS_PER_SAMPLE ' \ - '$OPUSENC_BITRATE --raw-rate $RATE --raw-chan $CHANNELS ' \ - '--raw-endianness $ENDIAN_OPUSENC ' \ - '$OPUSENC_COMMENTS ' \ - '- $OUTDIR$TRACKNUMBER.opus', - "format" => { - "bits" => 16, - "rate" => 48000, - "type" => "s16", - "channels" => 2, - }, - }, } @tracks = [] @infmt = nil # wait until input is assigned diff --git a/test/test_splitfx.rb b/test/test_splitfx.rb index adb3508..49df49d 100644 --- a/test/test_splitfx.rb +++ b/test/test_splitfx.rb @@ -70,35 +70,6 @@ class TestSplitfx < Testcase cmp = "cmp result.s32 expect.s32" assert system(cmp), cmp - - # try Ogg Opus, use opusenc/opusdec for now since that's available - # in Debian 7.0 (sox.git currently has opusfile support, but that - # hasn't made it into Debian, yet) - if `which opusenc 2>/dev/null`.size > 0 && - `which opusdec 2>/dev/null`.size > 0 - WAIT_ALL_MTX.synchronize do - tmp_err('opus.err.txt') { sfx.run("opusenc", opts) } - end - assert_contains_stats('opus.err.txt') - - # ensure opus lengths match flac ones, we decode using opusdec - # since sox does not yet have opus support in Debian 7.0 - %w(1 2).each do |nr| - cmd = "opusdec #{nr}.opus #{nr}.wav 2>/dev/null" - assert system(cmd), cmd - assert_equal `soxi -D #{nr}.flac`, `soxi -D #{nr}.wav` - end - - # ensure 16/44.1kHz FLAC works (CDDA-like) - File.unlink('1.flac', '2.flac') - WAIT_ALL_MTX.synchronize do - tmp_err('flac-cdda.err.txt') { sfx.run("flac-cdda", opts) } - end - assert_contains_stats('flac-cdda.err.txt') - %w(1 2).each do |nr| - assert_equal `soxi -D #{nr}.flac`, `soxi -D #{nr}.wav` - end - end end end end -- EW